<html>
<head><meta charset="utf-8"><title>PR Review comment duplicates? · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html">PR Review comment duplicates?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220435227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/PR%20Review%20comment%20duplicates%3F/near/220435227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html#220435227">(Dec 18 2020 at 22:22)</a>:</h4>
<p>(slightly off topic) so, I just reviewed <a href="https://github.com/rust-lang/rust-clippy/pull/6464">https://github.com/rust-lang/rust-clippy/pull/6464</a>, left a reply to a comment as part of the review and added a review summary as well.<br>
Is it normal that GH is showing my comment twice now, because that seems slightly annoying? I think I will just separate replies and review comments from now on <span aria-label="neutral" class="emoji emoji-1f610" role="img" title="neutral">:neutral:</span></p>



<a name="220435931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/PR%20Review%20comment%20duplicates%3F/near/220435931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html#220435931">(Dec 18 2020 at 22:31)</a>:</h4>
<p>Did you click <code>Add single comment</code> or <code>Start a Review</code>? Just guessing here.</p>



<a name="220436224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/PR%20Review%20comment%20duplicates%3F/near/220436224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html#220436224">(Dec 18 2020 at 22:34)</a>:</h4>
<p>Yeah, I clicked 'Start a review' and then replied to the comment as part of the review (if that explanation makes sense)</p>



<a name="220436286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/PR%20Review%20comment%20duplicates%3F/near/220436286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html#220436286">(Dec 18 2020 at 22:34)</a>:</h4>
<p>Yes, that's a GH "feature". pretty annoying. You can't even resolve the duplicated review comment, without resolving the whole thread.</p>



<a name="220436361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/PR%20Review%20comment%20duplicates%3F/near/220436361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html#220436361">(Dec 18 2020 at 22:35)</a>:</h4>
<p>oh, alright! then it's just some weird UX to keep in mind <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="220436666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/PR%20Review%20comment%20duplicates%3F/near/220436666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/PR.20Review.20comment.20duplicates.3F.html#220436666">(Dec 18 2020 at 22:39)</a>:</h4>
<p>I will start a review to leave a comment on your comment-review, reminding you that your comment is a review, not just a comment.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>